Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: contribution guide for docs #2962

Merged
merged 8 commits into from
Apr 8, 2024
Merged

docs: contribution guide for docs #2962

merged 8 commits into from
Apr 8, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Apr 6, 2024

🧭 What and Why

Improve contribution guidelines for adding new clients and the documentation aspects of it.

Changes included:

  • Edit the "Add new clients" guide to give it a clearer structure and edit for style.
  • Add a new "docs" guide to define elements where we want to achieve consistent docs.
  • Add the remark-smartypants plugin to render straight quotes as "correct" quotes.
  • Left-align table headers (looks better IMO)

I'll update the specs to follow these guidelines in a separate PR.

Add a new guide for writing API docs, which pins down the format
for descriptions and summaries of APIs, operations, and parameters.
Also support rendering correct quotes instead of plain ones.:
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 6, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

github-actions bot commented Apr 6, 2024

@github-actions github-actions bot temporarily deployed to pull request April 6, 2024 08:58 Inactive
@kai687 kai687 marked this pull request as ready for review April 6, 2024 09:37
@kai687 kai687 requested a review from a team as a code owner April 6, 2024 09:37
@github-actions github-actions bot temporarily deployed to pull request April 7, 2024 08:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 7, 2024 10:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 7, 2024 12:13 Inactive
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a w e s o m e

website/package.json Outdated Show resolved Hide resolved
website/docs/contributing/docs.md Outdated Show resolved Hide resolved
shortcuts
shortcuts previously approved these changes Apr 7, 2024
shortcuts
shortcuts previously approved these changes Apr 7, 2024
@shortcuts shortcuts merged commit bd75f37 into main Apr 8, 2024
13 checks passed
@shortcuts shortcuts deleted the docs/contribute branch April 8, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants